fix(FR-2622): add delete-folder option and trash notification on model card deletion by agatha197 · Pull Request #6881 · lablup/backend.ai-webui

agatha197 · 2026-04-22T05:42:47Z

Resolves #6841 (FR-2622)

Summary

Added vfolderId field to AdminModelCardListPageQuery so the model card's associated vfolder ID is available in the deletion flow.
Added AdminModelCardListPageDeleteVFolderMutation (deleteVfolderV2) to soft-delete (move to trash) the associated model folder.
Added alsoDeleteFolder state (default false) that resets when the deletion dialog closes.
Added an opt-in Checkbox (wrapped in Tooltip) to the single-delete BAIDeleteConfirmModal via the extraContent prop, allowing admins to also trash the associated model folder in the same action.
Updated the onOk handler: when checked, deleteVfolderV2 is called after card deletion; both paths show a notification.success with a "Go to Data > Trash" action button navigating to /data?statusCategory=deleted (with folder filter when folder is also deleted).
Added new i18n keys under adminModelCard in en.json: AlsoDeleteModelFolder, AlsoDeleteModelFolderTooltip, ModelCardAndFolderDeleted, ModelCardDeletedFolderKept, GoToTrash.

agatha197 · 2026-04-22T05:43:01Z

test(FR-2652): add E2E tests for admin model card deletion with folder option #6887 : 2 dependent PRs (#6969 , #7135 )
fix(FR-2651): list all model-store folders when creating a model card #6888
chore(FR-2622): add i18n translations for delete-folder option #6883
fix(FR-2622): add delete-folder option and trash notification on model card deletion #6881 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-22T05:45:54Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	8.11% (-0% 🔻)	1859/22932
🔴	Branches	7.34% (-0.01% 🔻)	1187/16168
🔴	Functions	4.82% (+0.01% 🔼)	297/6161
🔴	Lines	7.88% (-0% 🔻)	1750/22217

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from 19752e5

Copilot

Pull request overview

Adds an optional “delete associated model folder” flow when deleting an admin model card, and replaces the plain success toast with a notification that can deep-link users to the Trash view.

Changes:

Added new adminModelCard.* i18n strings for the new checkbox/tooltip and deletion result notifications.
Updated AdminModelCardListPage delete confirmation modal to include an “also delete folder” checkbox and (optionally) run deleteVfolderV2, followed by a success notification with a “Go to Data > Trash” action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
resources/i18n/en.json	Adds new English strings for delete-folder option and trash navigation notification.
react/src/pages/AdminModelCardListPage.tsx	Adds delete-folder checkbox, new vfolder delete mutation, and a post-delete trash notification with navigation.

ironAiken2

test을(를) 입력하여 확인하세요. The translated text seems a little awkward. 'Please enter <folder name> to delete.' How does that sound?

github-actions · 2026-04-28T06:48:18Z

Coverage report for `./packages/backend.ai-ui`

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	81.87%	429/524
🟡	Branches	70.43%	362/514
🟡	Functions	76.86%	93/121
🟢	Lines	83.19%	391/470

Test suite run success

319 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 19752e5

ironAiken2

test을(를) 입력하여 확인하세요. The translated text seems a little awkward. 'Please enter <folder name> to delete.' How does that sound?

Please check this comment

ironAiken2

LGTM

…l card deletion

…-input association without breaking controlled input Form.Item with `name` uses cloneElement to inject its own value/onChange, overiding the explicit controlled value/onChange on Input. This caused typedText to never update, keeping the Delete button permanently disabled. Fix: let Form own the input state via Form.useForm + Form.useWatch, and remove explicit value/onChange from Input.

github-actions · 2026-05-04T23:59:40Z

Coverage Report for backend-ai-ui-coverage (./packages/backend.ai-ui)

Status	Category	Percentage	Covered / Total
🔵	Lines	7.67%	322 / 4197
🔵	Statements	6.94%	368 / 5298
🔵	Functions	8.6%	88 / 1023
🔵	Branches	6.15%	321 / 5212

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/backend.ai-ui/src/components/BAIDeleteConfirmModal.tsx	0%	0%	0%	0%	9-134

Generated in workflow #267 for commit 6f30d94 by the Vitest Coverage Report Action

github-actions · 2026-05-05T00:00:42Z

Coverage Report for react-coverage (./react)

Status	Category	Percentage	Covered / Total
🔵	Lines	6.54%	1783 / 27223
🔵	Statements	5.42%	1978 / 36475
🔵	Functions	5.21%	296 / 5681
🔵	Branches	3.82%	1293 / 33842

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
react/src/pages/AdminModelCardListPage.tsx	0%	0%	0%	0%	62-600

Generated in workflow #267 for commit 6f30d94 by the Vitest Coverage Report Action

Copilot AI review requested due to automatic review settings April 22, 2026 05:42

github-actions Bot added area:ux UI / UX issue. area:i18n Localization labels Apr 22, 2026

github-actions Bot assigned agatha197 Apr 22, 2026

github-actions Bot added the size:L 100~500 LoC label Apr 22, 2026

Copilot started reviewing on behalf of agatha197 April 22, 2026 05:43 View session

agatha197 mentioned this pull request Apr 22, 2026

chore(FR-2622): add i18n translations for delete-folder option #6883

Open

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Comment thread resources/i18n/en.json

Comment thread react/src/pages/AdminModelCardListPage.tsx Outdated

Comment thread react/src/pages/AdminModelCardListPage.tsx

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch 6 times, most recently from 5a33b0a to 196618a Compare April 22, 2026 07:21

This was referenced Apr 22, 2026

test(FR-2652): add E2E tests for admin model card deletion with folder option #6887

Open

fix(FR-2651): list all model-store folders when creating a model card #6888

Open

agatha197 requested review from ironAiken2 and nowgnuesLee April 22, 2026 10:16

ironAiken2 requested changes Apr 23, 2026

View reviewed changes

Comment thread resources/i18n/en.json

Comment thread react/src/pages/AdminModelCardListPage.tsx

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 196618a to 2763cba Compare April 23, 2026 11:49

agatha197 requested a review from ironAiken2 April 23, 2026 11:49

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch 2 times, most recently from 893816e to b61a8af Compare April 24, 2026 07:53

agatha197 mentioned this pull request Apr 24, 2026

chore(FR-2652): update E2E coverage report — admin model store 26/26 (100%) #6969

Closed

5 tasks

agatha197 requested a review from yomybaby April 24, 2026 08:07

ironAiken2 requested changes Apr 27, 2026

View reviewed changes

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from b61a8af to cbde122 Compare April 28, 2026 06:45

agatha197 requested a review from ironAiken2 April 28, 2026 06:46

ironAiken2 requested changes Apr 28, 2026

View reviewed changes

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from cbde122 to 4fe4032 Compare April 28, 2026 08:00

agatha197 requested a review from ironAiken2 April 28, 2026 08:02

ironAiken2 approved these changes Apr 28, 2026

View reviewed changes

This was referenced Apr 28, 2026

feat(FR-2622): add bulk vfolder trash support on model card bulk deletion #7135

Open

test(FR-2622): add E2E tests for bulk vfolder trash on model card bulk deletion #7137

Open

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 4fe4032 to 6d6f443 Compare April 30, 2026 04:34

agatha197 mentioned this pull request Apr 30, 2026

test(FR-2652): fix parallel interference and folder-dialog flakiness in delete spec #7162

Open

2 tasks

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 6d6f443 to 19752e5 Compare April 30, 2026 08:44

agatha197 added 2 commits May 5, 2026 08:47

fix(FR-2622): add delete-folder option and trash notification on mode…

c3f323e

…l card deletion

agatha197 force-pushed the 04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion branch from 19752e5 to 6f30d94 Compare May 4, 2026 23:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(FR-2622): add delete-folder option and trash notification on model card deletion#6881

fix(FR-2622): add delete-folder option and trash notification on model card deletion#6881
agatha197 wants to merge 2 commits intomainfrom
04-22-fix_fr-2622_add_delete-folder_option_and_trash_notification_on_model_card_deletion

agatha197 commented Apr 22, 2026 •

edited

Loading

Uh oh!

agatha197 commented Apr 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ironAiken2 left a comment

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

ironAiken2 left a comment

Uh oh!

ironAiken2 left a comment

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

agatha197 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

agatha197 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./packages/backend.ai-ui

Test suite run success

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 4, 2026

Coverage Report for backend-ai-ui-coverage (./packages/backend.ai-ui)

Uh oh!

github-actions Bot commented May 5, 2026

Coverage Report for react-coverage (./react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agatha197 commented Apr 22, 2026 •

edited

Loading

agatha197 commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

Coverage report for `./react`

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Coverage report for `./packages/backend.ai-ui`